[PATCH] D97748: [SystemZ][z/OS] Add support to validate a HLASM Label.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

In D97748#2604956 <https://reviews.llvm.org/D97748#2604956>, @anirudhp wrote:

>> And the current implementation here expects UTF-8 (or that's what the internal character encoding is assumed to be anyway). There's a patch for `-fexec-charset` and the string being parsed here went into the IR in what form?
>
> Currently, the asm string goes into the IR in ASCII, irrespective of the `-fexec-charset` option.

Numeric escapes will be a problem (because any usage of such in HLASM inline assembly is not likely to be encoding for UTF-8). I don't know how common such usage is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97748/new/

https://reviews.llvm.org/D97748