[PATCH] D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:447
+  }
+    LLVM_FALLTHROUGH;
   case PPC::F8RCRegClassID:
----------------
I think it best to avoid the fallthrough.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:450
   case PPC::F4RCRegClassID:
-  case PPC::VRRCRegClassID:
   case PPC::VFRCRegClassID:
   case PPC::VSLRCRegClassID:
----------------
VFRC is the sub registers of the vsx registers that 'overlap' the VRs, so when we only have 20 vr, then we only have 20 subregistes as well.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:455
   case PPC::VSSRCRegClassID:
     return 64 - DefaultSafety;
+  case PPC::VSRCRegClassID: {
----------------
All three of these reg classes will have the same count, since if we reduce the vector registers by 12, then we also lose the sub registers of those vector registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351