[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

Fri Mar 5 05:30:57 PST 2021

abhina.sreeskantharajan added inline comments.

================
Comment at: clang/lib/Frontend/FrontendActions.cpp:841
     }
   }

----------------
amccarth wrote:
> The preceding block that detects the type of line separator seems ripe for factoring out into a separate function.  It's a lot of low-level detail that visually outweighs the primary intent of this method.
> 
> But I'm fine with the change as it doesn't impact Windows and--as far as I understand--Posix platforms don't distinguish between text and binary mode.
Right, my intention was not to change the current behaviour, but only limit it to Windows which is the only affected platform.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97785/new/

https://reviews.llvm.org/D97785