[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

>From a Windows point of view, this LGTM.



================
Comment at: clang/lib/Frontend/FrontendActions.cpp:841
     }
   }
 
----------------
The preceding block that detects the type of line separator seems ripe for factoring out into a separate function.  It's a lot of low-level detail that visually outweighs the primary intent of this method.

But I'm fine with the change as it doesn't impact Windows and--as far as I understand--Posix platforms don't distinguish between text and binary mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97785/new/

https://reviews.llvm.org/D97785