[compiler-rt] 579fd02 - [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 00:44:11 PST 2021


Author: Rainer Orth
Date: 2021-03-05T09:43:47+01:00
New Revision: 579fd0259788e8dcd4c2a26b5eefdd0d78cd4093

URL: https://github.com/llvm/llvm-project/commit/579fd0259788e8dcd4c2a26b5eefdd0d78cd4093
DIFF: https://github.com/llvm/llvm-project/commit/579fd0259788e8dcd4c2a26b5eefdd0d78cd4093.diff

LOG: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris

One ASan test currently `XPASS`es on Solaris:

  AddressSanitizer-i386-sunos :: TestCases/Posix/unpoison-alternate-stack.cpp

It was originally `XFAIL`ed in D88501 <https://reviews.llvm.org/D88501>
because `longjmp` from a signal handled is highly unportable, warned
against in XPG7, and was not supported by Solaris `libc` at the time.

However, since then support has been added for some cases including the
current one, so the `XFAIL` can go.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.

Differential Revision: https://reviews.llvm.org/D97933

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
index 4774993cdf32..7fe8971a7d56 100644
--- a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
@@ -7,8 +7,6 @@
 // RUN: %run %t
 
 // XFAIL: ios && !iossim
-// longjmp from signal handler is unportable.
-// XFAIL: solaris
 
 #include <algorithm>
 #include <cassert>


        


More information about the llvm-commits mailing list