[compiler-rt] 1d0dee5 - [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 5 00:43:04 PST 2021


Author: Rainer Orth
Date: 2021-03-05T09:42:29+01:00
New Revision: 1d0dee51daaff2204ea9b9939717651f6556bcb5

URL: https://github.com/llvm/llvm-project/commit/1d0dee51daaff2204ea9b9939717651f6556bcb5
DIFF: https://github.com/llvm/llvm-project/commit/1d0dee51daaff2204ea9b9939717651f6556bcb5.diff

LOG: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris

One ASan test currently `XPASS`es on Solaris:

  AddressSanitizer-i386-sunos :: TestCases/Posix/no_asan_gen_globals.c

It was originally `XFAIL`ed in D88218 <https://reviews.llvm.org/D88218>
because Solaris `ld`, unlike GNU `ld`, doesn't strip local labels.  Since
then, the integrated assembler has stopped emitting those local labels, so
the difference becomes moot and the `XFAIL` can go.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.

Differential Revision: https://reviews.llvm.org/D97932

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c b/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
index c9a6d99aca23..994f827974be 100644
--- a/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
+++ b/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
@@ -1,7 +1,5 @@
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
 // XFAIL: android
-// Bug 47607
-// XFAIL: solaris
 // Make sure ___asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe


        


More information about the llvm-commits mailing list