[PATCH] D97949: [AArch64] Add missing intrinsics for vrnd

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:484
 
 // v8.6-A Matrix Multiply Intrinsics
   def int_aarch64_neon_ummla : AdvSIMD_MatMul_Intrinsic;
----------------
SjoerdMeijer wrote:
> Nit and unrelated: but perhaps you can fix the indent here.
Yep, I will update it.


================
Comment at: llvm/test/CodeGen/AArch64/v8.5a-neon-frint3264-intrinsic.ll:1
+; RUN: llc < %s -mtriple=aarch64-eabi -mattr=+v8.5a,+fptoint  | FileCheck %s
+
----------------
SjoerdMeijer wrote:
> Nit: fptoint seems to be implied by v8.5a, so don't need to specify it here?
Oops! You are right! I will update it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97949/new/

https://reviews.llvm.org/D97949