[PATCH] D97949: [AArch64] Add missing intrinsics for vrnd

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 11:48:32 PST 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:484
 
 // v8.6-A Matrix Multiply Intrinsics
   def int_aarch64_neon_ummla : AdvSIMD_MatMul_Intrinsic;
----------------
Nit and unrelated: but perhaps you can fix the indent here.


================
Comment at: llvm/test/CodeGen/AArch64/v8.5a-neon-frint3264-intrinsic.ll:1
+; RUN: llc < %s -mtriple=aarch64-eabi -mattr=+v8.5a,+fptoint  | FileCheck %s
+
----------------
Nit: fptoint seems to be implied by v8.5a, so don't need to specify it here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97949/new/

https://reviews.llvm.org/D97949



More information about the llvm-commits mailing list