[PATCH] D96931: [LTO] Discard non-prevailing defined symbols in module-level assembly

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 20:49:19 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/test/LTO/X86/weak-asm.ll:37
+
+ at llvm.used = appending global [1 x i8*] [i8* bitcast (i32 (i32)* @bar to i8*)], section "llvm.metadata"
+
----------------
Nit: this can be `llvm.compiler.used`

llvm.used on ELF get SHF_GNU_RETAIN now. We don't need that stricter semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96931/new/

https://reviews.llvm.org/D96931



More information about the llvm-commits mailing list