[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

Tue Mar 2 17:19:14 PST 2021

smeenai added a comment.

In D92808#2593331 <https://reviews.llvm.org/D92808#2593331>, @ahatanak wrote:

> In D92808#2593204 <https://reviews.llvm.org/D92808#2593204>, @thakis wrote:
>
>> FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when arc is used (simulator is fine though): https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11
>>
>> We'll try to investigate a bit more on our side, but I wanted to give an early(ish) heads-up in case others see this or whatnot.
>>
>> Not sure if this landed before or after the 12.0 branch.
>
> Thank you. Let me know when you have more information.
>
> This isn't in release/12.x. The older version of the patch, which used attributes instead of operand bundles, was in release/12.x, but got reverted later.

Just to confirm, the revert is also in release/12.x, so I don't think there's any branch concerns here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808