[PATCH] D95638: AMDGPU: Add target id and code object v4 support

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl marked 2 inline comments as done.
kzhuravl added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5128
   case AMDGPU::XNACK_MASK_HI:
-    return (isVI() || isGFX9()) && hasXNACK();
+    return (isVI() || isGFX9()) && getTargetStreamer().getTargetID()->isXnackSupported();
   case AMDGPU::SGPR_NULL:
----------------
arsenm wrote:
> The subtarget still has the register even if xnack isn't enabled
supported != enabled. isXnackSupported returns true for every ASIC that supports xnack, false otherwise. To check whether xnack is enabled or not, one can check the return value of getXnackSetting and see if it is "On":

https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h#L108


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95638/new/

https://reviews.llvm.org/D95638