[PATCH] D95638: AMDGPU: Add target id and code object v4 support

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4525
+
+  if (const auto &&HsaAbiVer = AMDGPU::getHsaAbiVersion(&ST)) {
+    switch (HsaAbiVer.getValue()) {
----------------
Why &&? I also have no idea what this type is, so I think the auto hurts


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4526
+  if (const auto &&HsaAbiVer = AMDGPU::getHsaAbiVersion(&ST)) {
+    switch (HsaAbiVer.getValue()) {
+    case ELF::ELFABIVERSION_AMDGPU_HSA_V2:
----------------
I'm guessing this is an Optional, in which case *HasAbiVer


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5128
   case AMDGPU::XNACK_MASK_HI:
-    return (isVI() || isGFX9()) && hasXNACK();
+    return (isVI() || isGFX9()) && getTargetStreamer().getTargetID()->isXnackSupported();
   case AMDGPU::SGPR_NULL:
----------------
The subtarget still has the register even if xnack isn't enabled


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95638/new/

https://reviews.llvm.org/D95638