[PATCH] D96399: [X86][CodeGenPrepare] Try to reuse IV's incremented value instead of adding the offset

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 10:22:39 PST 2021


reames added a comment.

Pushed 6af94d22 <https://reviews.llvm.org/rG6af94d22f7b0f7f5edd84ad9ae96fd801dbf017d> which defers the domtree compute slightly further.

As an aside, the analysis invalidation in this code is a mess.  We appear to be leaving loopinfo (which is derived from DT) stale.  It just happens that the particular variety of stale doesn't expose problems in practice (joy).  It's also not clear why we don't just update DT in the various transforms which modify it.  None of them appear particularly hard to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96399/new/

https://reviews.llvm.org/D96399



More information about the llvm-commits mailing list