[PATCH] D96399: [X86][CodeGenPrepare] Try to reuse IV's incremented value instead of adding the offset

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 10:11:14 PST 2021


reames added a comment.

In D96399#2604070 <https://reviews.llvm.org/D96399#2604070>, @nikic wrote:

> For most programs the regression is resolved, only mafft still has a noteworthy regression, as well as the ReleaseLTO-g configurations (don't know if related to the LTO part or the `-g` part though).

How concerned by this are you?  To me this looks relatively isolated, and likely directly related to code changes in the respective benchmarks.  (Though, is that an easy way to check that without building it all myself?)  I can see one more small tweak I can make to defer domtree usage a bit further (will do so), but at some point it's pretty fundamental to this change (which I do think is worthwhile).  Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96399/new/

https://reviews.llvm.org/D96399



More information about the llvm-commits mailing list