[PATCH] D97812: [mir] Fix confusing MIR when MMO's value is nullptr but offset is non-zero

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 09:38:19 PST 2021


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Daniel,

> We might want to consider something more direct like 'unknown'. Any thoughts on the spelling to use?

I agree that "unknown" would be easier to understand but I think we can fix that in a follow-up patch if that proves to be non-trivial. The current printing is super confusing anyway so this is an improvement IMO :).

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97812/new/

https://reviews.llvm.org/D97812



More information about the llvm-commits mailing list