[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 12:54:06 PST 2021


rnk added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
       CmdArgs.push_back("-guard:cf-");
+    } else if (GuardArgs.equals_lower("ehcont")) {
+      CmdArgs.push_back("/guard:ehcont");
----------------
pengfei wrote:
> rnk wrote:
> > This is gone now, btw
> Sorry, I don't understand by the mean "gone"? The check for cf is still there after I rebased, I think we should do for ehcont too.
Oh, I misspoke. I assumed this was code for doing fall back to cl.exe, which was removed recently. Nevermind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96709/new/

https://reviews.llvm.org/D96709



More information about the llvm-commits mailing list