[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 19:17:40 PST 2021


pengfei added a comment.

Thanks for the review.



================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
       CmdArgs.push_back("-guard:cf-");
+    } else if (GuardArgs.equals_lower("ehcont")) {
+      CmdArgs.push_back("/guard:ehcont");
----------------
rnk wrote:
> This is gone now, btw
Sorry, I don't understand by the mean "gone"? The check for cf is still there after I rebased, I think we should do for ehcont too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96709/new/

https://reviews.llvm.org/D96709



More information about the llvm-commits mailing list