[PATCH] D97578: [instcombine] Collapse trivial or/and recurrences

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D97578#2600668 <https://reviews.llvm.org/D97578#2600668>, @lebedev.ri wrote:

> This looks reasonable to me, but is this falling into the traditional pitfail of not dealing with all of the commutative variants, etc?
> What happens if `BinaryOperator`'s both operands are recurrences, and the first one isn't the one we can deal with? (`DT.dominates(Step, PN)`)

Honestly, I wouldn't bother to handle this case.  It really seems like perfection being the enemy of the good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97578/new/

https://reviews.llvm.org/D97578