[PATCH] D97578: [instcombine] Collapse trivial or/and recurrences

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 09:35:17 PST 2021


lebedev.ri added a comment.

This looks reasonable to me, but is this falling into the traditional pitfail of not dealing with all of the commutative variants, etc?
What happens if `BinaryOperator`'s both operands are recurrences, and the first one isn't the one we can deal with? (`DT.dominates(Step, PN)`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97578/new/

https://reviews.llvm.org/D97578



More information about the llvm-commits mailing list