[PATCH] D97867: [lld-macho] Filter TAPI re-exports by target

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/Config.h:87
+
+  llvm::MachO::Target target() const {
+    return llvm::MachO::Target(arch, platform.kind);
----------------
nit: could this be called `makeTarget`? `target()` alone sounds like an accessor, which it technically isn't.

Otherwise (keeping the name), can it be cached/shared? How many time does it need to create a target? 

(It seems from the usages below, we only need it for comparison, so it seems safe to do that to me)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97867/new/

https://reviews.llvm.org/D97867