[PATCH] D97867: [lld-macho] Filter TAPI re-exports by target

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously, we were loading re-exports without checking whether
they were compatible with our target. Prior to D97209: [lld-macho] Check for arch compatibility when loading ObjFiles and TBDs <https://reviews.llvm.org/D97209>, it meant that
we were defining dylib symbols that were invalid -- usually a silent
failure unless our binary actually used them. D97209 <https://reviews.llvm.org/D97209> exposed this as an
explicit error.

Along the way, I've extended our TAPI compatibility check to cover the
platform as well, instead of just checking the arch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97867

Files:
  lld/MachO/Config.h
  lld/MachO/InputFiles.cpp
  lld/test/MachO/Inputs/libStubLink.tbd
  lld/test/MachO/invalid/Inputs/libincompatible.tbd
  lld/test/MachO/invalid/incompatible-arch-tapi.s
  lld/test/MachO/invalid/incompatible-target-tapi.test
  lld/test/MachO/stub-link-by-arch.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97867.327816.patch
Type: text/x-patch
Size: 5708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210303/d12555b1/attachment.bin>