[PATCH] D97604: [SystemZ] Reimplement the 1-byte compare-and-swap logic

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 01:16:05 PST 2021


uweigand added a comment.

The change in lowerATOMIC_CMP_SWAP should be removed now.   Otherwise this LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:4060
+  // emitAtomicCmpSwapW() will zero extend the result (original value).
+  SDValue OrigVal = DAG.getNode(ISD::AssertZext, DL, WideVT, AtomicOp.getValue(0),
+                                DAG.getValueType(NarrowVT));
----------------
This is not needed any more -- it is already done by common code now that you set getAtomicExtendOps to ZERO_EXTEND.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97604/new/

https://reviews.llvm.org/D97604



More information about the llvm-commits mailing list