[PATCH] D88287: [NARY-REASSOCIATE] Support reassociation of min/max

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 22:31:55 PST 2021


lebedev.ri added a comment.

In D88287#2599227 <https://reviews.llvm.org/D88287#2599227>, @ebrevnov wrote:

>> I actually think this patch should not have been reverted in the first place.
>> SCEV is known to be not good with `undef`, i don't really see why we should start blocking on that now.
>> So i would personally recommend to directly revert your revert.
>
> If I'm getting it right you are OK to commit the patch in its current state. If this is the case please unblock it.

Sure can do, but i don't want to unblock/accept *this* current code state, so please upload the result of `git revert`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88287/new/

https://reviews.llvm.org/D88287



More information about the llvm-commits mailing list