[PATCH] D97827: GlobalISel: Add default implementation of assignValueToReg

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 21:56:23 PST 2021


aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:214
+    /// Insert G_ASSERT_ZEXT/G_ASSERT_ZEXT or other hint instruction based on \p
+    /// SrcReg, returning the new register if a hint was inserted.
+    Register buildExtensionHint(CCValAssign &VA, Register SrcReg, LLT NarrowTy);
----------------
Should say "based on \p VA" since that has the information needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97827/new/

https://reviews.llvm.org/D97827



More information about the llvm-commits mailing list