[PATCH] D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector

Luke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 19:24:22 PST 2021


luke957 marked an inline comment as not done.
luke957 added a comment.

In D97549#2596672 <https://reviews.llvm.org/D97549#2596672>, @frasercrmck wrote:

> The changes LGTM, thanks for adding a test case.
>
> However, I think the commit title/message could be expanded upon somewhat. For example, *how* does it improve LoopVectorizer support? Since we've got both fixed-length and scalable vectorization, I think it would be helpful to clarify that this relates to fixed-length vectorization. More specifically, doesn't this change *enable* fixed-length vectorization, not just improve upon it?

Thanks for the review and advice. I have rewritten the title and message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97549/new/

https://reviews.llvm.org/D97549



More information about the llvm-commits mailing list