[PATCH] D97485: PowerPC][AIX] Handle variadic vector formal arguments.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 2 inline comments as done and an inline comment as not done.
sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCCCState.h:41
+
+class AIXCCState : public CCState {
+private:
----------------
sfertile wrote:
> cebowleratibm wrote:
> > Should this derive from PPCCCState?  If not, I think PPCCCState should be renamed something to indicate not AIX because AIX is still a PPC calling convention.
> IIUC PPCCCState is exclusively used by the 32-bit ELF target. When we add support for fp128 on AIX we might need the same functionality for 32-bit AIX at which point we would probably inherit from it instead of the base class. I can rename PPCCCState to ELF32CCState (I need to double check it is indeed only used by the 32-bit target first)
I'll put the rename into a separate NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97485/new/

https://reviews.llvm.org/D97485