[PATCH] D97757: [lld-macho] Rework length check when opening input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 06:05:33 PST 2021


thakis added inline comments.


================
Comment at: lld/test/MachO/rename.s:17
 # BAD1-DAG: error: invalid name for segment or section: -o
-# BAD1-DAG: error: file is too small to contain a magic number:
+# BAD1-DAG: error: /dev/null: unhandled file type
 
----------------
Looks like on Windows /dev/null is replaced with a temp file:

```
ld64.lld: error: C:\Users\ContainerAdministrator\AppData\Local\Temp\lit_tmp_xrue9d5c\tmprj2ybz87: unhandled file type
```

So probably use `{{.*}}` as file name here and below,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97757/new/

https://reviews.llvm.org/D97757



More information about the llvm-commits mailing list