[PATCH] D97757: [lld-macho] Rework length check when opening input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 06:03:54 PST 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks, much nicer :)

It's important to keep in mind that 99.9% of lld invocations (on non-Win) are through clang, and clang will never pass /dev/null as an input file (unless you try really hard, with `-Wl,/dev/null`. So I don't even think crashing on this input would be all that terrible. But if it can be prevented with a simple one-line fix, then fixing is fine too I suppose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97757/new/

https://reviews.llvm.org/D97757



More information about the llvm-commits mailing list