[PATCH] D97729: [ARM] Improve WLS lowering

Tue Mar 2 03:18:31 PST 2021

SjoerdMeijer added inline comments.

================
Comment at: llvm/docs/LangRef.rst:15719
+
+'``llvm.test.start.loop.iterations.*``' Intrinsic
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
Let's separate the LangRef part out and let's make this patch depends on that.

I think the spec change can be a bit more precise:
- *integer* values are expected and produced,
- are there no surprises in behaviour for some corner case values, like the value 0?
- would be good to say what the values actually represents.

Following from this, but correct me if I am wrong, I believe there are a few things we could check: we are expecting the same integer types, which I think could be verifier checks, and we could even check the same (constant) values. I am not entirely sure if that belongs in Verifier.cpp or Lint.cpp, but somewhere there I guess?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97729/new/

https://reviews.llvm.org/D97729