[PATCH] D88287: [NARY-REASSOCIATE] Support reassociation of min/max

Tue Mar 2 01:46:28 PST 2021

lebedev.ri added a comment.

In D88287#2596715 <https://reviews.llvm.org/D88287#2596715>, @ebrevnov wrote:

>> Uhm, no? SCEV only supports integers and pointers.
>
> I looked at the failing list one more time and indeed it was a pointer to double case.... In total, there are 54 failing tests which needs to be investigated...

I actually think this patch should not have been reverted in the first place.
SCEV is known to be not good with `undef`, i don't really see why we should start blocking on that now.
So i would personally recommend to directly revert your revert.

> Roman, Are you working in this direction?
> SCEV Expander should be fixed separately anyway and I don't think there is strong dependence between these pieces.

Right now i'm not looking at that, but i already had a patch to fix this,
but got sidetracked into `isHighCostExpansion()`, which then resulted in rage-closing IDE...
Right now i'm trying to deal with another SCEV issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88287/new/

https://reviews.llvm.org/D88287