[PATCH] D97641: [lld/mac] Add support for -flat_namespace

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 09:18:01 PST 2021


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:705
+          reinterpret_cast<const char *>(c) + read32le(&c->dylib.name);
+      ::loadDylib(dylibPath, umbrella);
+    }
----------------
int3 wrote:
> hm is the `::` prefix necessary?
judging from the test failures, I guess we need to account for syslibroot here too


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97641/new/

https://reviews.llvm.org/D97641



More information about the llvm-commits mailing list