[PATCH] D97641: [lld/mac] Add support for -flat_namespace

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/InputFiles.cpp:705
+          reinterpret_cast<const char *>(c) + read32le(&c->dylib.name);
+      ::loadDylib(dylibPath, umbrella);
+    }
----------------
hm is the `::` prefix necessary?


================
Comment at: lld/test/MachO/flat-namespace.s:38-39
+
+# No "(dynamically looked up)" because llvm-nm -m doesn't print that
+# for files without MH_TWOLEVEL for some reason.
+# FLATSYM: (undefined) external _bar
----------------
does `llvm-objdump --syms` or `llvm-readobj` print anything better?


================
Comment at: lld/test/MachO/header.s:15-16
 
 # CHECK:      magic        cputype cpusubtype  caps    filetype
-# CHECK-NEXT: MH_MAGIC_64  {{.*}}         ALL  [[CAPS]]   {{.*}}
+# CHECK-NEXT: MH_MAGIC_64  {{.*}}         ALL  [[CAPS]]   {{.*}} TWOLEVEL
 
----------------
ultra nit: align the header


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97641/new/

https://reviews.llvm.org/D97641