[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 12:51:43 PST 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/MC/MCContext.h:586-590
     getXCOFFSection(StringRef Section, SectionKind K,
                     Optional<XCOFF::CsectProperties> CsectProp = None,
                     bool MultiSymbolsAllowed = false,
-                    const char *BeginSymName = nullptr);
+                    const char *BeginSymName = nullptr,
+                    unsigned SecFlags = 0);
----------------
hubert.reinterpretcast wrote:
> Use `Optional` with a suitable enumeration type.
It may make sense to add a `getXCOFFDwarfSection` function that forwards to this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518



More information about the llvm-commits mailing list