[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a subscriber: DiggerLin.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/DebugInfo/XCOFF/empty.ll:75-77
+; ASM32-NEXT:  L..func_end0:
+; ASM32-NEXT:                                          # -- End function
+; ASM32-NEXT:  L..sec_end0:
----------------
See comment about the size of the traceback table and the resulting alignment consequences.


================
Comment at: llvm/test/DebugInfo/XCOFF/empty.ll:276-278
+; ASM64-NEXT:  L..func_end0:
+; ASM64-NEXT:                                          # -- End function
+; ASM64-NEXT:  L..sec_end0:
----------------
Because the size of the traceback table is not a guaranteed to be a multiple of 4 (here it is 22 bytes), I think it may be more conservative to actually emit these labels immediately after the last code instruction (although it seems neither GCC nor XL on AIX do that). Alternatively (and GCC and XL both do so), padding should be emitted after the traceback table to maintain the alignment. @DiggerLin @jasonliu, if the second option (add padding) is chosen, I think it should be a separate patch that is a follow-up to the traceback table emission.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518