[PATCH] D97637: [DAGCombiner][X86] Don't peek through ANDs on the shift amount in matchRotateSub when called from MatchFunnelPosNeg.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 28 12:34:53 PST 2021


RKSimon accepted this revision.
RKSimon added a comment.

LGTM



================
Comment at: llvm/test/CodeGen/X86/shift-double.ll:487
 
 define i32 @shld_safe_i32(i32, i32, i32) {
 ; X86-LABEL: shld_safe_i32:
----------------
lebedev.ri wrote:
> Indeed:
> https://godbolt.org/z/641T9c
> https://alive2.llvm.org/ce/z/5eK7nf
> 
probably not "safe" then......


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97637/new/

https://reviews.llvm.org/D97637



More information about the llvm-commits mailing list