[PATCH] D97637: [DAGCombiner][X86] Don't peek through ANDs on the shift amount in matchRotateSub when called from MatchFunnelPosNeg.

Sun Feb 28 11:44:34 PST 2021

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Hm, i recall viewing the original patch back then, not sure why i didn't catch that :/
LGTM

================
Comment at: llvm/test/CodeGen/X86/shift-double.ll:487

 define i32 @shld_safe_i32(i32, i32, i32) {
 ; X86-LABEL: shld_safe_i32:
----------------
Indeed:
https://godbolt.org/z/641T9c
https://alive2.llvm.org/ce/z/5eK7nf

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97637/new/

https://reviews.llvm.org/D97637