[PATCH] D97238: [Attributor] Conditinoally delete fns

Sat Feb 27 10:11:17 PST 2021

sstefan1 added inline comments.

================
Comment at: llvm/test/Transforms/Attributor/nodelete.ll:1
+; RUN: opt -attributor-cgscc -S < %s | FileCheck %s
+
----------------
wsmoses wrote:
> jdoerfert wrote:
> > sstefan1 wrote:
> > > Maybe generate this with `update_test_checks.py`? I guess it would be easier to update and also for consistency.
> > I missed this. Use the same run lines as other tests and the update test script please.
> Using the same line as others reveals a similar issue for non cgss mode. Is it preferable to leave those tests disabled for the moment (like below) or to also disable function removal for that mode?
I guess we should do that while we are at it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97238/new/

https://reviews.llvm.org/D97238