[PATCH] D97238: [Attributor] Conditinoally delete fns

[William Moses via Phabricator via llvm-commits]

wsmoses marked 2 inline comments as done.
wsmoses added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/nodelete.ll:1
+; RUN: opt -attributor-cgscc -S < %s | FileCheck %s
+
----------------
jdoerfert wrote:
> sstefan1 wrote:
> > Maybe generate this with `update_test_checks.py`? I guess it would be easier to update and also for consistency.
> I missed this. Use the same run lines as other tests and the update test script please.
Using the same line as others reveals a similar issue for non cgss mode. Is it preferable to leave those tests disabled for the moment (like below) or to also disable function removal for that mode?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97238/new/

https://reviews.llvm.org/D97238