[PATCH] D97483: [dfsan] Propagate origins for callsites

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao marked 2 inline comments as done.
stephan.yichao.zhao added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:691
+
+  if (shouldTrackOrigins()) {
+    ArgTypes.append(T->getNumParams(), OriginTy);
----------------
morehouse wrote:
> Aside:  We call this function a lot.  Maybe we should just set a bool during initialization and use that instead.
Added a static bool inside shouldTrackOrigins to catch the result.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:2451
+        Args.push_back(DFSF.OriginReturnAlloca);
+      }
+    }
----------------
morehouse wrote:
> Nit:  This function is already huge.  Is there a clean way to move this new logic into a helper function, and maybe share some of the similar logic with the shadow args above?
Added addShadowArguments and addOriginArguments. I should have refactored them before this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97483/new/

https://reviews.llvm.org/D97483