[PATCH] D97483: [dfsan] Propagate origins for callsites

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:691
+
+  if (shouldTrackOrigins()) {
+    ArgTypes.append(T->getNumParams(), OriginTy);
----------------
Aside:  We call this function a lot.  Maybe we should just set a bool during initialization and use that instead.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:2451
+        Args.push_back(DFSF.OriginReturnAlloca);
+      }
+    }
----------------
Nit:  This function is already huge.  Is there a clean way to move this new logic into a helper function, and maybe share some of the similar logic with the shadow args above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97483/new/

https://reviews.llvm.org/D97483