[PATCH] D94992: [SLP]Merge reorder and reuse shuffles.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4297
+          // instruction for the user vectorization factor and have to reshuffle
+          // it again to take only unique elements of the vector. Before this
+          // patch, the compiler incorrectly returned reduced vector instruction
----------------
anton-afanasyev wrote:
> This phrase "Before this patch..." looks misplaced here, inside comment. May be move it to summary?
Yes, will fix this part of the comment, thanks.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3503
     case Instruction::ExtractElement: {
+      InstructionCost DeadCost = 0;
       if (NeedToShuffleReuses) {
----------------
anton-afanasyev wrote:
> echristo wrote:
> > Let's describe dead cost here.
> May be just something like "CommonCost"? The "dead" part of cost is used at the end only.
Done. Also, forgot to add a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94992/new/

https://reviews.llvm.org/D94992