[PATCH] D94992: [SLP]Merge reorder and reuse shuffles.

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added a comment.

LG after addressing all comments.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4297
+          // instruction for the user vectorization factor and have to reshuffle
+          // it again to take only unique elements of the vector. Before this
+          // patch, the compiler incorrectly returned reduced vector instruction
----------------
This phrase "Before this patch..." looks misplaced here, inside comment. May be move it to summary?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3503
     case Instruction::ExtractElement: {
+      InstructionCost DeadCost = 0;
       if (NeedToShuffleReuses) {
----------------
echristo wrote:
> Let's describe dead cost here.
May be just something like "CommonCost"? The "dead" part of cost is used at the end only.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4339
 
+namespace {
+/// Merges shuffle masks and emits final shuffle instruction, if required.
----------------
ABataev wrote:
> echristo wrote:
> > I seem to recall we have other classes that do this as well?
> I did not find any. Could you point me where should I look for something similar?
Didn't find them as well...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94992/new/

https://reviews.llvm.org/D94992