[PATCH] D97545: [AMDGPU] Remove SI_MASK_BRANCH

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 06:35:08 PST 2021


ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertSkips.cpp:213
-// Returns true if a branch over the block was inserted.
-bool SIInsertSkips::skipMaskBranch(MachineInstr &MI,
-                                   MachineBasicBlock &SrcMBB) {
----------------
arsenm wrote:
> If SIInsertSkips is no longer inserting skips, it needs a new name
I don't have good idea on that. I am happy if some one could came up with a good name. And I believe that should be in a separate patch. This patch just aims to remove "SI_MASK_BRANCH".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97545/new/

https://reviews.llvm.org/D97545



More information about the llvm-commits mailing list