[PATCH] D97046: [lit] Add "late_tests" test suite config option

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 05:08:48 PST 2021


davezarzycki added a comment.

I've implemented the requested prefix matching but having done so, I'd like to request that we just replace `early_tests` with `test_phases` which is a dictionary of paths/path-prefixes to integers, where zero is the default phase and negative numbers represent early phases and positive numbers represent late stages. This gives users maximal flexibility.

If one wants minimal maintenance, then put just a few slow tests in the -1 phase.  (And Swift can its four compiler crash test prefixes in the +1 phase.)

If one doesn't mind regularly refreshing the dictionary, then by all means, commit a big list and use as many phases as you want.

Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97046/new/

https://reviews.llvm.org/D97046



More information about the llvm-commits mailing list