[PATCH] D97040: [llvm-objcopy][MachO] Add support for --keep-undefined

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Doc update? Also, do we need to add the unsupported option checks to the other file formats?



================
Comment at: llvm/tools/llvm-objcopy/CommonOpts.td:88
+def keep_undefined : Flag<["--"], "keep-undefined">,
+                        HelpText<"Do not remove undefined symbols">;
+
----------------
This probably wants a note saying this is Mach-O only.

More generally, it might be worth separating options for specific platforms into different parts of the help text, like some other tools do, and like the docs do. That's probably a separate issue though.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:535-537
+  if (Config.StripSwiftSymbols || Config.KeepUndefined)
     return createStringError(llvm::errc::invalid_argument,
                              "option not supported by llvm-objcopy for ELF");
----------------
Obvious question a user will ask: what option? I know this message was here before, but it probably wants improving, especially now that there is more than one option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97040/new/

https://reviews.llvm.org/D97040