[PATCH] D97421: [flang][fir] Add array value operations.

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:129
+  if (!eleTy)
+    return op.emitOpError("must be a reference or box type");
+  auto arrTy = eleTy.dyn_cast<fir::SequenceType>();
----------------
mehdi_amini wrote:
> The ODS definition specifies the operand as `AnyRefOrBox`, I'd think that should be enough to have a constraint already enforced. Do you have a test which would show this line reachable?
Removed. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97421/new/

https://reviews.llvm.org/D97421