[PATCH] D97421: [flang][fir] Add array value operations.
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 25 13:33:51 PST 2021
mehdi_amini added inline comments.
================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:129
+ if (!eleTy)
+ return op.emitOpError("must be a reference or box type");
+ auto arrTy = eleTy.dyn_cast<fir::SequenceType>();
----------------
The ODS definition specifies the operand as `AnyRefOrBox`, I'd think that should be enough to have a constraint already enforced. Do you have a test which would show this line reachable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97421/new/
https://reviews.llvm.org/D97421
More information about the llvm-commits
mailing list