[PATCH] D97345: Improve the debug info for coro-split .resume functions

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 18:05:45 PST 2021


ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:847
                     CloneFunctionChangeType::LocalChangesOnly, Returns);
+  // Adjust the scope line of the clone to the line number of the suspend point.
+  if (DISubprogram *SP = NewF->getSubprogram()) {
----------------
Since this code only works under continuation and async ABIs. So it maybe better to add comment or add explicit guard-if to tell the semantic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97345/new/

https://reviews.llvm.org/D97345



More information about the llvm-commits mailing list