[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu marked an inline comment as done.
myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:1
+//===-- M68kInstrArithmetic.td - Integer Arith Instrs ----*- tablegen -*-===//
+//
----------------
jrtc27 wrote:
> I think is needed to line it up, though check for yourself, it's hard to tell in this view
yes this is needed, thanks


================
Comment at: llvm/lib/Target/M68k/M68kRegisterInfo.td:73
+
+// TODO get rid of "pseudo" registers and use just MxReg variants and use
+// HWEncoding's other 13 bits to encode type(and potentially other info) of
----------------
jrtc27 wrote:
> They already are using MxReg?
you're right, this comment is outdated


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389