[PATCH] D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D97484#2588003 <https://reviews.llvm.org/D97484#2588003>, @hans wrote:

> In D97484#2587991 <https://reviews.llvm.org/D97484#2587991>, @lebedev.ri wrote:
>
>> Why isn't the solution is to fix the uses to prevent variable substitution in them?
>> Because of course `$1` is substituted with a value of variable `1` in shell, and elsewhere.
>>
>>   $ c++filt _Z3foov\$123
>>   _Z3foov$123
>
> Sorry, I should have used quotes. But your example shows that the name is still not getting demangled. Compare that with a period as separator:
>
>   $ c++filt _Z3foov.123
>   foo() [clone .123]
>
> Now it demangles, and puts the suffix on the side.

Thank you, please make that more obvious in the patch's description :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97484/new/

https://reviews.llvm.org/D97484